Add Clippy lint workspace configuration #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckysori
force-pushed
the
chore/workspace-clippy-lints
branch
from
f24f803 to
2cf4293
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 9, 2023
235: Add Clippy lint workspace configuration r=luckysori a=luckysori We've used a similar pattern in past projects. One thing that has changed is that we use `[target.'cfg(feature = "cargo-clippy")']` instead of `[build]`. This allows us to enforce this lint configuration locally and not just on CI. Using `rustflags` does mean that devs might encounter unexpected full rebuilds when switching between IDE and command line when using `cargo clippy`. This is a known [issue]. For emacs, I just solved this by setting a different Cargo `target-directory` to the one used by default. A similar approach should work for other IDEs. [issue]: rust-lang/cargo#8716. Co-authored-by: Lucas Soriano del Pino <lucas_soriano@fastmail.com>
|
Build failed: |
We've used a similar pattern in past projects. One thing that has changed is that we use `[target.'cfg(feature = "cargo-clippy")']` instead of `[build]`. This allows us to enforce this lint configuration locally and not just on CI. Using `rustflags` does mean that devs might encounter unexpected full rebuilds when switching between IDE and command line when using `cargo clippy`. This is a known issue[1]. For emacs, I just solved this by setting a different Cargo `target-directory` to the one used by default. A similar approach should work for other IDEs. [1]: rust-lang/cargo#8716.
luckysori
force-pushed
the
chore/workspace-clippy-lints
branch
from
2cf4293 to
47b8cf3
Compare
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've used a similar pattern in past projects.
One thing that has changed is that we use
[target.'cfg(feature = "cargo-clippy")']instead of[build]. This allows us to enforce this lint configuration locally and not just on CI.Using
rustflagsdoes mean that devs might encounter unexpected full rebuilds when switching between IDE and command line when usingcargo clippy. This is a known issue. For emacs, I just solved this by setting a different Cargotarget-directoryto the one used by default. A similar approach should work for other IDEs.